Very good point - I'll add a default case here.

Thanks!
Chris


On Feb 26, 2013, at 7:25 AM, "Dominique Dumont" <notifications@github.com<mailto:notifications@github.com>> wrote:


In deimos/source/designer/iframe/iframe.js:

> +                     this.selectItem(msg.val);
> +             } else if(msg.op === "highlight") {
> +                     this.highlightDropTarget(this.getControlById(msg.val.id));
> +             } else if(msg.op === "modify") {
> +                     this.modifyProperty(msg.val);
> +             } else if(msg.op === "unhighlight") {
> +                     this.unhighlightDropTargets();
> +             } else if(msg.op === "drop") {
> +                     this.simulateDrop(msg.val);
> +             } else if(msg.op === "newControl") {
> +                     this.simulateCreateNewComponent(msg);
> +             } else if(msg.op === "codeUpdate") {
> +                     this.codeUpdate(msg.val);
> +             } else if(msg.op === "cleanUp") {
> +                     this.cleanUpKind();
> +             }


There's should be here an else statement to catch programming mistakes done on Deimos side. A typo is too easy to make when designing message. An alert on unexpected message would really help debugging (been there, done that :-p )

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/ares-project/pull/222/files#r3154353>.