Updated PR.  Also added PEP-8 fixes.  You may disagree with these based on a previous conversation -- however, I've found it to be helpful enough in the past that I've adopted it as a habit.  I'm OK either way, obviously.


On Aug 8, 2013, at 7:36 AM, Matthew Rocklin <notifications@github.com> wrote:

> In itertoolz/core.py:
> 
> > @@ -171,3 +171,15 @@ def distinct(seq):
> >      True
> >      """
> >      return len(seq) == len(set(seq))
> > +
> > +def frequencies(seq):
> > +    """ Find number of occurrence of each value
> > +
> > +    >>> frequencies(["cat", "pig", "cat", "trout", "pig", "dog",
> Suggestions
> 
> Put result on output line. I understand that this depends on consistent ordering of keys. Have nose skip this doctest by adding # doctest: +SKIP to the end of the line.
> You could then add this test into test_core.py. Also, is there anything else we should test about this function?
> See if it's possible to keep the input on one line (not a big deal though).
> —
> Reply to this email directly or view it on GitHub.
>