I didn't mean it like that. You're totally right it would be ugly. 

I meant to check wether the setting is set or not. Of course there would be cases where the additional address in the body is not necessary. But like you said it wouldn't hurt either. 



Am 03.09.2013 um 12:18 schrieb Manolis Stamatogiannakis <notifications@github.com>:

> In cmsplugin_contact/cms_plugins.py:
> 
> > @@ -106,18 +106,24 @@ class ContactForm(self.contact_form, HoneyPotContactForm):
> >          else:
> >              return FormClass(request)
> >  
> > -    def send(self, form, site_email, attachments=None):
> > -        subject = form.cleaned_data['subject']
> > -        if not subject:
> > -            subject = _('No subject')
> > +    def send(self, form, form_name, site_email, attachments=None):
> > +        subject = form.cleaned_data['subject'] if form.cleaned_data['subject'] else _('No subject')
> > +        body = render_to_string(self.email_template, { 'data': form.cleaned_data, 'form_name': form_name, })
> > +        if hasattr(settings, 'DEFAULT_FROM_EMAIL'):
> Checking EMAIL_HOST for Google SMTP would be ugly and unreliable.
> 
> Ugly: You should check for several different DNS names (smpt.gmail.com, smtp.googlemail.com, gmail-smtp.l.google.com). You don't want this stuff in your codebase :-)
> 
> Unreliable: A common linux server configuration is to run an SMTP server locally which relays outgoing email to a smarthost (e.g. Google SMTP). So, your EMAIL_HOST could point to 127.0.0.1 while still using Google SMTP or some other service.
> 
> —
> Reply to this email directly or view it on GitHub.