if the line break is just for the '=' I'd make sure it is due to being
longer than 120 chars.  if not, join it, is my view.



On Mon, Apr 8, 2013 at 4:31 PM, Andrew Phillips <notifications@github.com>wrote:

> In
> apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/EC2ListNodesStrategy.java:
>
> > @@ -96,15 +120,50 @@ protected EC2ListNodesStrategy(EC2AsyncClient client, @Region Supplier<Set<Strin
> >     }
> >
> >     protected Iterable<? extends RunningInstance> pollRunningInstances() {
> > -      Iterable<? extends Set<? extends Reservation<? extends RunningInstance>>> reservations = transformParallel(
> > -               regions.get(), new Function<String, ListenableFuture<? extends Set<? extends Reservation<? extends RunningInstance>>>>() {
> > -
> > -                  @Override
> > -                  public ListenableFuture<? extends Set<? extends Reservation<? extends RunningInstance>>> apply(String from) {
> > -                     return client.getInstanceServices().describeInstancesInRegion(from);
> > -                  }
> > +      Iterable<? extends Set<? extends Reservation<? extends RunningInstance>>> reservations
> > +         = transform(regions.get(), allInstancesInRegion());
>
> Interesting style question: does = go on the declaring line or this line?
> I'd tend towards
>
> ...reservations =
>     transform(...
>
> but have no real preference - whatever jclouds prefers ;-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/1502/files#r3705310>
> .
>