retry r237702: rAc: pop tooltip icon bubble

with fix for crash.

BUG=322802

Review URL: https://codereview.chromium.org/99643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238816 0039d316-1c4b-4281-b951-d872f2087c98
SVN changes up to revision 238816
Register BCKS-based preferences before the PrefService is created.

Rename BCKBaseFactory::RegisterUserPrefsOnBrowserContext to BKCBaseFactory::RegisterUserPrefsOnBrowserContextForTest and make sure it is indeed only used in tests (the only non-test use of it to register something early in browser_prefs.cc was removed as it is no longer necessary now that registration is actually done early enough).

Rename methods/variables centered around calling RegisterUserPrefsOnBrowserContextForTest in BCKServiceFactory and its ref-counted twin to highlight the fact that those are test only and help justify calling test-only method RegisterUserPrefsOnBrowserContextForTest as a result of them being set.

This could be much simpler the day PrefService::DeprecatedGetPrefRegistry() is phased out and replaced by a better solution for tests, but currently this is the simplest we can do to achieve the desired product behavior without completely refactoring the test framework. Comments were added to reflect what could be simplified should it ever go away.

TBR=pkasting,rickcam (for unit_tests side-effects of suffixing a method with "ForTest")
BUG=324520

Review URL: https://codereview.chromium.org/97383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238817 0039d316-1c4b-4281-b951-d872f2087c98
SVN changes up to revision 238817