not what I meant - I mean that we want to be able to check out what we've
checked in and diff it against their code to see what lines we've tweaked.
If we run those files through hooks like that we can get some major diffs
on those files


----------------------------------------
Scott Stanchfield
http://javadude.com


On Mon, Nov 25, 2013 at 3:40 PM, Gabe Gorelick <notifications@github.com>wrote:

> In LICENSE.txt:
>
> > +	see: http://code.google.com/r/mitchellsundt-logfactory/source/browse
> > +
> > +https://bitbucket.org/javarosa/javarosa/wiki/Home		/Apache 2.0/
> > +	javarosa-libraries.jar
> > +
> > +	Modified from the core distribution.
> > +	see https://bitbucket.org/m.sundt/javarosa/src/
> > +
> > +http://joda-time.sourceforge.net/ 		/Apache 2.0/
> > +	joda-time-2.0.jar
> > +
> > +http://kxml.sourceforge.net/kxml2/		/BSD license/
> > +	kxml2-2.3.0.jar
> > +	
> > +http://code.google.com/p/regexp-me/		/Apache 2.0/
> > +	regexp-me.jar
>
> For sure, you shouldn't touch upstream. But that commit hook should only
> touch files you're committing. That's what git diff-index --cached is
> doing. But you would still need to add some logic to restrict it to patches
> that change the end of the file. Still probably not worth it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sages-health/sagesmobile-mCollect/pull/4/files#r7904128>
> .
>