LP#1160343: remove unused open-ils.circ settings

The circ_modifier and billing_types lists in the
open-ils.circ section of opensrf.xml are no longer
used.  This commit removes them from the opensrf.xml
example config.  It also removes the method
open-ils.circ.billing_type.retrieve.all, which has
not be used by any other code once in-DB billing types
were introduced.

Any external clients that used the method that was
removed should instead use
open-ils.circ.billing_type.ranged.retrieve.all.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
MARC strip fields for Acquisitions

Added MARC strip field group selector to acquisitions upload interface
in the same manner as the group selector for non-acq Vandelay

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
More authority fixed-field cleanup

Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits.  This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Undo holding lib to SRE linkage (alt dist editor)

Since the legacy record dropdown piggy-backs on the OPAC display, it
doesn't work in the alt interface (which has no clear OPAC context).

Worse, this leads to a Javascript error on the first editor load for
the distribution list, preventing subsequent editors.

A better fix will require more consideration, but for now, let's
revert to the unformatted display used in 2.3.

Also, this commit removes an unnecessary conditional (it was always
true).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Org unit prox adjustment tweaks

1) UI change - pre-select highest OU where user can edit

There's a dropdown in the org unit proximity adjustment interface that
affects the scope of what you can see in the table below.  Before, that
dropdown would be set to the user's home UO (say, BR1 in the example org
tree).  But you might have the permission to make changes everywhere, so
you add a proximity adjustment that affects BR3 in some way.  As soon as
you'd refresh the interface, your new proximity adjustment would not be
visible, because your scope selector would default to BR1.

So now the dropdown defaults to the first context where you have the
permission, which in all but eccentric setups should be the highest OU
(and therefore broadest scope) where you have the permission.

This could also improve other interfaces in the future.  Anything that
invokes openils.User.buildPermOrgSelector() can pass -1 as the third
parameter to get the new behavior.

2) Change UNIQUE index at DB layer.

This prevents the creation of rows that would give the hold targeter
conflicting directives.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Stamping upgrade script for aoupa constraint fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
tpac : honor page locale in record detail copy grid

The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls.  This
solves the issue where copy location names, statuses, etc. are not
properly translated.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix reversed logic for hold "blob" notes

Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Allow access to public hold notes via hold "blob"

If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>