Sorry I thought that's what you were checking for. If it has the
attributes.  If its boolean then get is the way go.
On Nov 20, 2013 5:43 PM, "Mark McDowall" <notifications@github.com> wrote:

> In src/UI/Settings/MediaManagement/Naming/Wizard/NamingWizardView.js:
>
> > +                    }
> > +                }
> > +
> > +                if (this.model.get('includeQuality')) {
> > +                    if (this.model.get('replaceSpaces')) {
> > +                        this.standardEpisodeFormat += ' {Quality.Title}';
> > +                        this.dailyEpisodeFormat += ' {Quality.Title}';
> > +                    }
> > +
> > +                    else {
> > +                        this.standardEpisodeFormat += ' {Quality Title}';
> > +                        this.dailyEpisodeFormat += ' {Quality Title}';
> > +                    }
> > +                }
> > +
> > +                if (this.model.get('replaceSpaces')) {
>
> I replaced everything with has and it completely broke it, started
> treating all the boolean values as being true even when they were set to
> false. Reading the docs: "Returns true if the attribute is set to a
> non-null or non-undefined value." Sounds like false should fall under that,
> but regardless, I like the readability of get better, has to me reads as
> does this model have this property, yes? then return true. get on the other
> hand gets the property value and returns based on its actual value, could
> extend it to be === true, but I think that its fine as is.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NzbDrone/NzbDrone/pull/38/files#r7813298>
> .
>