That one was my first implementation... although I do agree that on a
commandline the proper syntax should be the current one. Let me even mildly
suggest that hibernate tools shouldn't use the regular syntax approach
because it might trick users into using more complex expressions wich are
not actually supported.

Best regards
José
On 8 May 2013 08:24, "Max Rydahl Andersen" <notifications@github.com> wrote:

> In
> src/main/java/org/hibernate/forge/generate/DefaultReverseEngineeringStrategyWithSchemaSelection.java:
>
> > +	 * @param schemas
> > +	 *            The schemas to use ( FOO* matches any schema named FOOX,
> > +	 *            FOOBAR, FOO, etc)
> > +	 * @param tables
> > +	 *            The tables to use ( FOO* matches any table named FOOX, FOOBAR,
> > +	 *            FOO, etc)
> > +	 */
> > +	public DefaultReverseEngineeringStrategyWithSchemaSelection(
> > +			String catalogs, String schemas, String tables) {
> > +
> > +		String catalog = catalogs == null ? Constants.CATALOG_DEFAULT
> > +				: catalogs;
> > +		String schema = schemas == null ? Constants.SCHEMA_DEFAULT : schemas;
> > +		String table = tables == null ? Constants.TABLE_DEFAULT : tables;
> > +
> > +		catalog = StringHelper.replace(catalog, "*", "%");
>
> this should also be ".*", "%" to follow the syntax supported by
> hibernatetools - I see no reason why we would introduce a different one
> here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/forge/plugin-hibernate-tools/pull/16/files#r4129427>
> .
>