exit cleanup in functions

we should always use die instead of exit so that we know why we
failed.

Also remove instances where exit is called after die, as that is
a noop.

Change-Id: I8e08cce63d35c503c36ff1e09805f3db427d082d
whitespace cleanup on functions & lib/config

fix some of the bash8 issues found in functions and lib/config,
part of the long march towards fixing all the bash8 issues.

Change-Id: Ia131f64870acb0f9d196fe1a9a45d633abb6fc4d
fix bash8 indent problems in lib/neutron and friends

Change-Id: Ia83ce84b792494800fbfe7baa6423c8de9260014
fix whitespace in the rest of lib/*

this brings this in line with bash8 checker

Change-Id: Ib34a2292dd5bc259069457461041ec9cd4fd2957
clean up whitespace issues on exercises and friends

Change-Id: I812a73e46ddd4d5fed4d304d9ef92c1de243f497
clean up whitespace on stack.sh

Change-Id: If73435968cfbd0dd3cc519f0a30e02bec5fcb386
add support for heredoc folding of lines

this change in the parser allows for us to have heredocs folded
into logical lines.

Change-Id: I51ebe6cd7b89b5f7194e947896f20b6750e972e3
final bash8 files for the rest of devstack

With this devstack/master is bash8 clean, and ready for enforcement

Change-Id: I03fc89b401e6b7a23224d71472122c1bfa3ad0bd
Merge "exit cleanup in functions"