Hi Slava,
For this comment and all similar others. I was assuming that what we are giving now is not the absolute ultimate version of this stuff.
And stuff like this refinement can go in at a later stage. For now we need to have the full functionality in and we can adjust the details along the way.
Or not ?

 Nancy
______________________________________

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: slava77 <notifications@github.com<mailto:notifications@github.com>>
Reply-To: cms-sw/cmssw <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Mon, 28 Oct 2013 13:46:51 -0700
To: cms-sw/cmssw <cmssw@noreply.github.com<mailto:cmssw@noreply.github.com>>
Cc: Nancy Marinelli <nancy.marinelli@cern.ch<mailto:nancy.marinelli@cern.ch>>
Subject: Re: [cmssw] PF-Based Isolation for GED Electrons/Photons (#1174)


In RecoEgamma/EgammaPhotonProducers/src/GEDPhotonProducer.cc:

> @@ -46,19 +46,33 @@
>  {
>
>    // use onfiguration file to setup input/output collection names
> +  //
> +  photonProducer_       = conf_.getParameter<edm::InputTag>("photonProducer");
> +  if ( photonProducer_.label() == "gedPhotonCore" ) {


@lgray<https://github.com/lgray> @nancymarinelli<https://github.com/nancymarinelli> @beaudett<https://github.com/beaudett> @dbenedet<https://github.com/dbenedet>
This is a bit odd, too strict on naming of the input producer.
It makes more sense to create a switch parameter which would drive this if/else

—
Reply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/1174/files#r7262725>.