attrs update