LGTM :+1:
On Nov 18, 2013 10:14 PM, "atroche" <notifications@github.com> wrote:

> In app.js:
>
> > @@ -221,8 +221,28 @@
> >              name = field.attr('name');
> >
> >              if (!field.val()) {
> > -              alert( self.I18n.t('form.empty', { field: name.replace('_id', '').capitalize() }) );
> > +              var fieldName = name.replace('_id', '');
> > +              var fieldNameToTranslationName = {
> > +                'hours': "hours",
> > +                'notes': "notes",
> > +                'project': "select_project",
> > +                'task': "select_task"
> > +              };
> > +              var translationName = fieldNameToTranslationName[fieldName];
> > +              var translatedFieldName = self.I18n.t("form." + translationName);
> > +              var errorMessage  = self.I18n.t('form.empty', { field: translatedFieldName });
> > +
> > +              var modalId = _.uniqueId();
>
> Because there were situations where two modals were being created, and you
> need to be able to manipulate one and not the other.
>
> ?
> Reply to this email directly or view it on GitHub<https://github.com/zendesk/freshbooks_app/pull/4/files#r7741326>
> .
>