Thanks! Made the change accordingly.


On Wed, Dec 18, 2013 at 12:06 PM, P. Oscar Boykin
<notifications@github.com>wrote:

> In
> summingbird-scalding/src/main/scala/com/twitter/summingbird/scalding/DirectoryBatchedStore.scala:
>
> > +import com.twitter.summingbird.option._
> > +import com.twitter.summingbird.batch.{ BatchID, Batcher}
> > +
> > +/**
> > + * DirectoryBatched Scalding Store, which only contains (K, V) data pairs in the data.
> > + * Batch information is presented in directory pathes.
> > + *
> > + * @author Kevin Lin
> > + */
> > +
> > +class DirectoryBatchedStore[K <: Writable, V <: Writable](val rootPath: String)
> > +(implicit inBatcher: Batcher, ord: Ordering[K], tset: TupleSetter[(K, V)], tconv: TupleConverter[(K, V)])
> > +  extends BatchedScaldingStore[K, V] {
> > +  import Dsl._
> > +
> > +  var writtenBatches = Set[BatchID]()
>
> I can't see how this works. I think the var has to go and ONLY the
> filesystem can hold the state. I don't think you need it in any case. See
> below?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/summingbird/pull/407/files#r8448985>
> .
>



-- 
Kevin Lin | Twitter, Inc.
1355 Market St. | San Francisco, CA | 94103

Follow me: @reconditesea <https://twitter.com/reconditesea>