On 09/03/13 21:39, Karl Palsson wrote:
>
> In lib/stm32/common/timer_common_all.c:
>
> >  #define ADVANCED_TIMERS (defined (TIM1_BASE) || defined(TIM8_BASE))
> > -#	include <libopencm3/stm32/f2/timer.h>
> > -#	include <libopencm3/stm32/f2/rcc.h>
> > -#elif defined(STM32F4)
> > -#define ADVANCED_TIMERS (defined (TIM1_BASE) || defined(TIM8_BASE))
> > -#	include <libopencm3/stm32/f4/timer.h>
>
> I don't see ADVANCED_TIMERS being redefined anywhere else. TIM1_BASE 
> isn't defined in the L1 memory map, how does this work? (Or was that 
> trick fixed elsewhere, and this is just removing the evidence?)
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/libopencm3/libopencm3/pull/120/files#r3307761>.
>
Not really sure what you mean. ADVANCED_TIMERS is still defined there. 
This will be false for L1 and true for all others, which is what is 
wanted to rip out parts of the code for L1. A bunch of preprocessor 
stuff was removed as it was family specific which isn't needed now. 
Unless I missed something, which isn't improbable.

Your other comment is reasonable. I thought it was getting a bit 
haphazard but didn't see the purpose. It's a matter of opinion, I'm not 
fussed either way.