Acq general search: improve searching for negative comparisons

This aims to address Launchpad bug #1031535.  I think the bug only
really shows up when searches involve invoices either as the core type
or with filter fields.  If a search doesn't involve invoices, the
problematic joins aren't present.

Could use more testing though.  Seems to make the problem go away, and
other basic searches seem to work, but I certainly haven't tested
everything.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Copying 2.3.8-2.3.9 SQL upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Move HTML tags out of translatable strings in toolkit templates.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Make C unit tests more robust

Adding -I@abs_top_srcdir@/Open-ILS/include will pull in the source tree
header files, so that the C unit tests can run before Evergreen has been
installed (and thus will be a valid test of the source header files
instead of relying on the installed versions that might be different).

Build c-apps before recursing into c-apps/tests:
This ensures that the required libraries are built before the C unit
tests are built, thus preventing "make check" on a just-configured
source tree from failing due to missing dependencies.

Also, link to the source tree directories first rather than last, to
ensure that we pull in the correct source (if possible). And remove the
cargo-cultish $(TMP) linking/including.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Invoke skull-and-crossbones popup in batch receive for server-side errors

And introduce a minor bumper rail to guide serials users who might try
to hand-edit a holding code.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Conflicts:
    Open-ILS/xul/staff_client/server/serial/batch_receive.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
silence some unitialized warnings

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Acq: Honor new dist forumula fields in old method of applying formulae

The batch updater came with new fields on distribution formulae, but we
didn't teach the pre-existing code for applying formulae from the
lineitem copies interface to apply values from the new fields.

Reported by Jennifer Pringle in Launchpad bug report #1195521.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Remove JSPAC-oriented PasswordReset.pm interface

A native TPAC interface for resetting passwords arrived some time ago,
and the i18n for PasswordReset.pm predated the more standardized
approach taken by TPAC. So... kill the JSPAC interface and save
ourselves a little bit of Apache overhead in the process.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Propagating 2.3.10 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Repair remaining Authority Fixed Field editor entries

The "Item" fixed field is only valid for MFHD records, so we remove
that entirely from AUTH records.  The "GeoSubd" fixed field is
spelled "GeoDiv" everywhere, so we align that naming so that it can
be saved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Remove [ and ] characters from seriestitle index LP#1187521

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Stamping upgrade script for series title normalizer improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP1183467 ACQ view funding source list permissions

Limit the set of funding sources visible in the funding source list
interface by those the user has view permissions for, not just those the
user has edit permissions for.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix A/T object cache

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add placeholder file for 0821 upgrade script

0821 was added as a backport fix for 2.3 and 2.4, but not master.

Signed-off-by: Ben Shum <bshum@biblio.org>
LP1182519 Per-Hold Behind Desk Value

The true/false value for behind_desk is now stored directly on the hold
object for more accurate tracking of the location of captured holds.
If configured, patrons can now set their preferred value for behind the
desk holds.

 * DB/IDL changes to support the new column
 * API support for loading the setting from the patron for cases when no
   value is provided by the caller.
 * Staff client grid column definition for the Behind Desk field
 * Hold counts in the staff client now show total, available, and
   behind-desk (at the workstation).
 * Printed hold receipt now uses the behind_desk value on the hold to
   decide if a hold is behind the desk.
 * Release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Conflicts:

	Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm

Resolved 2 conflicts in Actor.pm sub hold_request_count
Retained the parameters as:
  my( $self, $client, $authtoken, $user_id, $ctx_org) = @;

And retained:

my @ready = grep { .... } @$holds code.

Signed-off-by: Garry Collum <gcollum@gmail.com>
LP#1182519 Stamping DB upgrade 0822

Signed-off-by: Bill Erickson <berick@esilibrary.com>
LP1207396 DB / IDL for patron self-reg

Updating pending addr tables to track requesting user and address county.

Adding org settings:

* opac.allow_pending_user -- allow self-registration
* opac.pending_user_expire_interval - delete pending user interval
* ui.patron.edit.aua.county.require - indicate if county is required

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP1207396 purge old pending users

Script to delete pending user accounts based on the interval defined in
the opac.pending_user_expire_interval org unit setting.

Add /openils/bin/purge_pending_users.srfsh to opensrf's CRON.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>