for 11/19 basic function is done