Hmmm if you mean to wrap the actual error message and pass it on, I can
do that. That looks reasonable.

LZ

On Mon, Dec 09, 2013 at 02:29:50AM -0800, Dominic Cleal wrote:
> > +    rescue Exception => e
> > +      logger.error "DNS virsh provider error: unable to parse virsh XML - #{e}"
> > +      logger.debug xml
> > +      raise e
> > +    end
> > +
> > +    def loadSubnetData subnet
> > +      super(subnet)
> > +      doc = REXML::Document.new xml = dump_xml
> > +      REXML::XPath.each(doc, "//network/ip[not(@family) or @family='ipv4']/dhcp/host") do |e|
> > +        Proxy::DHCP::Record.new(:subnet => subnet,
> > +                                :ip => e.attributes["ip"],
> > +                                :mac => e.attributes["mac"])
> > +      end
> > +    rescue Exception => e
> > +      logger.error "DNS virsh provider error: unable to parse virsh XML - #{e}"
> 
> ditto, too broad
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/smart-proxy/pull/116/files#r8193045

-- 
Later,

 Lukas "lzap" Zapletal
 irc: lzap #theforeman