Seems reasonable. Will do.


On Mon, Dec 23, 2013 at 7:58 AM, Jean-Paul Calderone <
notifications@github.com> wrote:

> In cryptography/hazmat/backends/openssl/ssl.py:
>
> > @@ -262,3 +262,15 @@
> >      int (*)(const SSL *, int *, void *)) = NULL;
> >  #endif
> >  """
> > +
> > +CONDITIONAL_NAMES = {
> > +    "SSLv2_method": "Cryptography_HAS_SSL2",
> > +    "SSLv2_client_method": "Cryptography_HAS_SSL2",
> > +    "SSLv2_server_method": "Cryptography_HAS_SSL2",
>
> You could invert this data structure. Map "Cryptography_HAS_SSL2" to {"SSLv2_method",
> "SSLv2_client_method", "SSLv2_server_method"} instead?
>
> Not a big deal, but perhaps slightly more convenient and logical.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/333/files#r8528879>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084