No, I meant s/block//. The line should read:
this.button_.style.display = enabled ? '' : 'none';

Setting display to the empty string resets display to its default value.
For buttons, that's usually "block", but it's possible that the user has
changed it to something different (like "table") for this particular
button. We shouldn't be presumptuous.


On Thu, Jan 10, 2013 at 10:57 PM, Robert Konigsberg <
notifications@github.com> wrote:

> In plugins/unzoom.js:
>
> > +
> > +    g.addEvent(parent, 'mouseover', function() {
> > +      if (g.isZoomed()) {
> > +        self.show(true);
> > +      }
> > +      self.over_ = true;
> > +    });
> > +
> > +    g.addEvent(parent, 'mouseout', function() {
> > +      self.show(false);
> > +      self.over_ = false;
> > +    });
> > +  };
> > +
> > +  unzoom.prototype.show = function(enabled) {
> > +    this.button_.style.display = enabled ? 'block' : 'none';
>
> Oh, you mean s/'none'/''. Done.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/danvk/dygraphs/pull/194/files#r2614524>.
>
>