generic was broken, needed to use salt->length and not strlen of salt