hi Richard,

Thanks for the feedback.  Here's some answers to your questions:

1. *improvement on semantic structure -* *When I saw the image alt-text, I
thought that it was acceptable for SEO or screen-readers, as both will
actively seek-out that alt-text.  I've often resisted adding elements to
'create' semantic markup, as I've oftentimes worked within CMS's where you
have no flexibility to allow for additional elements, so using alt-text
seemed like my only ally.  SEO and Accessibility standards are an
ever-changing bag-of-tricks that I've tried to keep an eye on, but I'm open
for any suggestions that will help improve this knowledge.*

2. *does the existing <h1> qualify as a heading - **The <h1> tag slipped by
me.  Generally, I am looking for one <h1> tag on a page (usually an easy
go-to is the logo-space, where I'll wrap the logo image in an <h1>).  This
was the only <h1> used on the page, so I didn't question it's usage based
on it's content.  I agree, at this point the <h1> is simply font-formatting
as the text "Stop by for a minute" isn't terribly telling about the page or
it's purpose.*

3.* global namespace 'mucking' -** It only occurred to me after the fact
that I could have wrapped this in a named object* *to protect it from the
global namespace*. *I understand and get the practice, but am more-used to
working with and creating isolated variables/functions in much larger
projects.  Being the only custom jquery for this 'project', my goal was to
keep it as simple as possible, hence this was relegated to an afterthought.*


I'm curious on 'the ideal fix' you were looking for on problems #1&2.  At
my previous post at VML (vml.com), I had the pleasure of working with some
very smart SEO folks.  I'm somewhat surprised they let me get away with
what I did on Kellogg's and SAP! (*no <h1> included*).  Looking back, I see
certain ways I could've made these sites better, from an SEO and
accessibility standpoint.  I've been locked-in a front-end-developer role
for six years, but I'm always trying to expand the knowledge-base on things
that are in my peripheral.

Thanks again for the opportunity!

eric

Eric Summers
esumm.webdev@gmail.com
www.esumm.com


On Mon, Jul 29, 2013 at 2:19 PM, Richard Jones <notifications@github.com>wrote:

> In www/js/main.js:
>
> > +		openModal('<strong>We&#39;ve got you locked in for the night of October 30th.</strong><br /><br />The event starts at 6pm. The later you arrive, the more drinks for the rest of us!  :-P','We&#39;ll see you there!');
> > +	} else {
> > +		// no, not going
> > +		openModal('Awww, we wish you could make it, but we understand.  Maybe next time?','We&#39;ll still keep you posted on future events.');
> > +	}
> > +});
> > +
> > +$('a.modal_close').on('click', function(){
> > +	closeModal();
> > +});	
> > +
> > +
> > +
> > +// jQuery modal functions
> > +
> > +function openModal(text1, text2) {
>
> How do you justify using the global namespace?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cpbtechnology/US-Frontend-Candidate-Lab/pull/12/files#r5460358>
> .
>