Easy change, ndb!


On 17 December 2013 14:49, Neil Costford <notifications@github.com> wrote:

> In lib/active_shipping/shipping/carriers/fedex.rb:
>
> > @@ -517,8 +531,12 @@ def parse_transit_times(times)
> >          results
> >        end
> >
> > -      def extract_destination(document)
> > -        node = document.elements['DestinationAddress'] || document.elements['ActualDeliveryAddress']
> > +      def extract_destination(document, possible_node_names)
>
> i'd rename this method since it's extracting addresses other than the
> destination now (shipper address) </nitpick>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Shopify/active_shipping/pull/127/files#r8414710>
> .
>



-- 
Chris Saunders // Developer @ Shopify