Looks like I am going to have to rebase and then update the PR again. 

I see that I got a message from OpenShift-bot saying that the PR can't be automerged. 

Respectfully, 



Martes G Wigglesworth 
Consultant - Middleware Engineer 
Red Hat Consulting 
Red Hat, Inc. 
Office Phone: 804 343 6084 - 8136084 
Office Email: mwiggles@redhat.com 

----- Original Message -----

From: "André Dietisheim" <notifications@github.com> 
To: "openshift/openshift-java-client" <openshift-java-client@noreply.github.com> 
Cc: "Martes Wigglesworth" <mwigglesworth@redhat.com> 
Sent: Friday, November 8, 2013 12:01:28 PM 
Subject: Re: [openshift-java-client] [JBIDE-15766]:Remove refresh of all IEnvironmentVariable(s) on add/remove actions (#100) 



In src/main/java/com/openshift/internal/client/ApplicationResource.java: 
> @@ -149,7 +151,7 @@
>  	/**
>  	 * The environment variables for this application
>  	 */
> -	private Map<String, IEnvironmentVariable> environmentVariableByName;
> +	private Map<String, IEnvironmentVariable> environmentVariablesMap; 


I would suggest keeping the "ByName" since its more explicit than the "Map", it tells you what the keys and what the values are. 

— 
Reply to this email directly or view it on GitHub .