Add attr and ignore
draft other apis