Explain why it is OK to not trigger IdentityFetcher command processing here.
Bug 0005820 which complains about this non-issue can be closed.
Use beginTrustListImport/finishTrustListImport in deleteWithoutCommit(Identity) instead of manually calling computeAllScoresWithoutCommit
This will be used to make sure that restoreIdentity does not trigger double score recomputation.
Call finishTrustListImport AFTER deleteWithoutCommit to make sure that the deletion of the identity does not trigger a second computeAllScoresWithoutCommit.
- Move updateLastInsertDate() to OwnIdentity.restoreEdition(): It
doesn't concern the actual trust graph so its misplaced in
WebOfTrust.restoreEdition():
* This fixes a missing identity.storeWithoutCommit() after the
updateLastInsertDate().
* Also, this gets rid of unneeded duplicate calling of
updateLastInsertDate()
- Move TODO with regards to insert date scheduling to
OwnIdentity.needsInsert(). It was quite misplaced in
WebOfTrust.restoreEdition(). Also, improve that TODO in depth of
explanation.
Add initial implementations of unit tests for restoreIdentity(). Not
finished yet in any way!
Rename restoreIdentity to restoreOwnIdentity to make the purpose more
clear.
Documentation
Update documentation: The said bug is closed already, it was not an issue, the deprecation for that reason was wrong.
Add some assert()s
Rename local variable to make it more explanatory
Get rid of deprecation of deleteWithoutCommit(Identity):
- It might be useful for testing for database object leaks.
- Therefore, this commit adds capslock to the JavaDoc which explains for what it should NOT be used.
- Also, it is explained what the function WOULD be useful for
- Notice that I have filed a bug for the suggested feature of leakage testing: https://bugs.freenetproject.org/view.php?id=5861
Improve documentation of restoreOwnIdentity
Add an assert()
Fix typo in logging and improve it to match the actual function name
Reduce loglevel to WARNING when trying to delete a Persistent object
which was not actually stored. It is not a severe problem.
Add some logging
Add more information to logging (toString() provides more than the nickname) and make it sound less like we are finished yet
Fix assert() failure in beginTrustListImport() by moving the call to begin..() to the proper location
Comment out bogus assert()s and explain why they won't work
Add some assert()s