SEACAS: exodiff - fix nodeset parameter read

(From Sierra)

Build/Test Cases Summary
Enabled Packages: SEACASExodiff
Disabled Packages: Panzer,PyTrilinos
Enabled all Forward Packages
0) MPI_DEBUG => Skipped configure, build, test due to no enabled packages! => Does not affect push readiness! (-1.00 min)
1) SERIAL_RELEASE => Skipped configure, build, test due to no enabled packages! => Does not affect push readiness! (-1.00 min)
2) MPI_DEBUG_SS => passed: passed=3,notpassed=0 (1.58 min)
3) SERIAL_RELEASE_SS => passed: passed=5,notpassed=0 (1.49 min)
Teuchos: Fixed compiler warning (return statement unreachable).
Ifpack2: Documented and reformatted BlockRelaxation.

Thanks to Tom Benson for implementing BlockRelaxation :-)  It's always
a bit scary to put a new class out there for users.  I decided to "lead
by doing" and illustrate documentation and code formatting standards for
Ifpack2, by using BlockRelaxation as an example and implementing those
standards.  Ifpack2 could use a lot of work in general, so I omitted the
more aggressive changes that would be more appropriate for a major
Ifpack2 refactor.

I also noticed that Ifpack2_BlockRelaxation_decl.hpp duplicated the
definition of the RelaxationType enum that was in
Ifpack2_Relaxation_decl.hpp.  To avoid duplicate definitions of this
enum, I moved it to Ifpack2_ConfigDefs.hpp.  I also put it in the
Ifpack2::Details namespace, since it is an implementation detail of
Ifpack2 and not meant for users.

Build/Test Cases Summary
Enabled Packages: Tpetra, Belos, Ifpack2
0) MPI_DEBUG => passed: passed=123,notpassed=0 (3.65 min)
1) SERIAL_RELEASE => passed: passed=106,notpassed=0 (9.85 min)
Other local commits for this build/test group: 21da0ed
Ifpack2: Reformatted, documented, and fixed integer conversion issues.

I moved the Doxygen documentation of the Ifpack2::Details namespace into
Ifpack2_ConfigDefs.hpp, and removed duplicated Doxygen documentation of
this namespace from other files.

I reformatted some of the newer classes (that relate to partitioning)
to conform to Ifpack2 conventions, and added or expanded public Doxygen
documentation.  While doing so, I noticed that OverlappingPartitioner
was storing NumLocalParts_ (the number of local subgraphs) as
GraphType::local_ordinal_type (LO), yet its documentation pointed out
that NumLocalParts_ had to be signed, because negative values of
NumLocalParts_ were significant.  LO may be either signed or unsigned;
Tpetra imposes no signedness requirements on LO.  Thus, I changed
NumLocalParts_ to an int.  I also added explicit integer type
conversions to the code to avoid warnings for signed / unsigned
comparisons.
Ifpack2: Improved code formatting and documentation.

I also removed a reference to Ifpack2::Details::Tpetra_RowGraph from
Ifpack2::LocalFilter.  It's not necessary to make a special subclass to
wrap Tpetra::RowMatrix in a Tpetra::RowGraph, because Tpetra::RowMatrix
already has a getGraph() method that returns its graph (as a
Tpetra::RowGraph).  In the next commit, I will remove Tpetra_RowGraph
entirely.
Ifpack2: Removed Ifpack2::Details::Tpetra_RowGraph.

Ifpack2::Details::Tpetra_RowGraph was a special subclass that wrapped
Tpetra::RowMatrix in a Tpetra::RowGraph.  However, this class is not
needed, because Tpetra::RowMatrix already has a getGraph() method that
returns the matrix's graph (as a Tpetra::RowGraph).  Thus, this commit
removes the superfluous class.
Ifpack2: Removed Ifpack2_ConstructLevelFillGraph.hpp.

The header file probably never even compiled, since it assumes C++11
parsing (RCP<CrsGraph<LO, GO>> rather than RCP<CrsGraph<LO, GO> >),
yet was written in the mid-2000s.  It's also incorrect, because it
passes output arguments (that it allocates) as RCP<CrsGraph>, rather
than RCP<CrsGraph>&.  (Those output arguments would never have made
it outside the function.)
Ifpack2: Container: Fixed and expanded public documentation.

Build/Test Cases Summary
Enabled Packages: Tpetra, Belos, Ifpack2
0) MPI_DEBUG => passed: passed=123,notpassed=0 (3.07 min)
1) SERIAL_RELEASE => passed: passed=106,notpassed=0 (0.43 min)
Other local commits for this build/test group: 29c51d3, 2e1b57a, cbe9c4ad, 1d82f5d
Panzer: Modifying how non-distributed parameters are handled

The p_init_ vector in the ME class is now initialized directly
from the parameter library. Now the initial conditions are properly
set to default parameter values (as opposed to 0).

Also added some convenience functions to the ParameterLibrary
utilities
Ifpack2: Cleaned up OverlappingRowMatrix and improved documentation.

I changed the typedefs to match Tpetra (as I've been doing with all of
Ifpack2's Tpetra::RowMatrix subclasses).  I also fixed some incorrect
use of integer types, like assigning
Teuchos::OrdinalTraits<global_size_t>::invalid() (generally unsigned)
to global_ordinal_type (usually, though not necessarily, signed).
Ifpack2: Cleaned up OverlappingRowMatrix a bit.
Ifpack2: Added OverlappingRowGraph class.

One issue with the current implementation of OverlappingRowMatrix is
that, even though it claims to implement Tpetra::RowMatrix, its
getGraph() method (that should return a Tpetra::RowGraph) is
unimplemented and throws an exception if called.  This motivated the
Ifpack2::Details::Tpetra_RowGraph class (that provides a graph "view"
of a Tpetra::RowMatrix) that I removed a few commits ago.  It's not
hard to write a Tpetra::RowGraph which works with the data in
OverlappingRowMatrix.  This commit adds Details::OverlappingRowGraph,
which implements Tpetra::RowGraph in this way.  I have not yet changed
OverlappingRowMatrix to create an instance of this class; that is the
logical next step.

OverlappingRowGraph is in the Details namespace for now, first because
I'm not certain about its interface (in particular, its constructor),
and second, because it is currently just an implementation detail of
OverlappingRowMatrix.

Note that OverlappingRowGraph is explicitly instantiated both for
GraphType=Tpetra::CrsGraph and for GraphType=Tpetra::RowGraph.
The CrsGraph explicit instantiation assumes the default Node and
LocalMatOps template parameters for Ifpack2's explicit instantiation
system.
Ifpack2: OverlappingRowMatrix: Implemented getGraph().

getGraph() was not implemented before; calling it would throw.  This
commit fixes that.  It implements the method by returning an instance
of the recently implemented Details::OverlappingRowGraph.  The latter
should be considered, for now at least, an implementation detail of
Ifpack2.

Build/Test Cases Summary
Enabled Packages: Tpetra, Belos, Ifpack2
0) MPI_DEBUG => passed: passed=123,notpassed=0 (2.90 min)
1) SERIAL_RELEASE => passed: passed=106,notpassed=0 (0.35 min)
Other local commits for this build/test group: a902fb6, 0dd4c9c, 85b6bf8
Ifpack2: Factory: Fixed discrepancy between documentation and code.

Build/Test Cases Summary
Enabled Packages: Tpetra, Belos, Ifpack2
0) MPI_DEBUG => passed: passed=123,notpassed=0 (2.86 min)
1) SERIAL_RELEASE => passed: passed=106,notpassed=0 (0.32 min)