You're right on both accounts. I'll update the PR as soon as I get a chance.

Thanks for spotting these!
________________________________
From: Philippe Miossec<mailto:notifications@github.com>
Sent: ‎2013-‎10-‎07 8:28 AM
To: git-tfs/git-tfs<mailto:git-tfs@noreply.github.com>
Cc: Dan Rigby<mailto:dan@danrigby.com>
Subject: Re: [git-tfs] Add support for VS2013 & TFS2013 (#464)

> +
> +        private static Assembly GetDialogAssembly()
> +        {
> +            return Assembly.LoadFrom(GetDialogAssemblyPath());
> +        }
> +
> +        private static string GetDialogAssemblyPath()
> +        {
> +            return Path.Combine(GetVs2012InstallDir(), "PrivateAssemblies", DialogAssemblyName + ".dll");
> +        }
> +
> +        private static string GetVs2012InstallDir()
> +        {
> +            return TryGetRegString(@"Software\Microsoft\VisualStudio\11.0", "InstallDir")
> +                ?? TryGetRegString(@"Software\WOW6432Node\Microsoft\VisualStudio\11.0", "InstallDir");
> +        }

I can't test this pull request because I don't have VS2013 and TFS2013, but...is it normal that the reg path is the same than VS2012?
Shouldn't that be `VisualStudio\12.0` (because that's the assembly version included in the csproj)?

And perhaps, we should rename the method to GetVs2013InstallDir()...

---
Reply to this email directly or view it on GitHub:
https://github.com/git-tfs/git-tfs/pull/464/files#r6795429