more work on share modal