updating func signature