Clean up effect.c

Also simplifies code in several places:
u16b flags = 0L;
flags |= (X);

to u16b flags = (X);