I'm just going to combine the rest of the comments into a single email.

1. Yes, that blurb of code is required on KitKit, or else it will crash. If
you've seen a rash of releases recently "To fix a crash on KitKat", I bet
that's what it is.
2. I'm going to keep the exceptions in place, instead of returning -1. I'd
rather thrown an exception in the case that something isn't right, because
it's easier to debug exceptions. And the exception thrown has actually
saved me a few times when debugging... I did change it to
IllegalStateException, per your suggestion, however.
3. I'm not entirely sure what you meant about the space/tabs. I've
"corrected indentation" on Eclipse, hopefully that clears it up.
4. No problem being a stickler. Part of the reason I wanted to do this was
to get someone else to look at a major block of code that combines things
that I've never done before, and it helps to have a second set of eyes.
I've rarely had someone who actually was a stickler about code look at
mine, so...
5. The main setting blurb, was that about the comments there? Essentially,
they came from Android when you create a new project, but I can get rid of
them, if you want. I'm guessing it was the last line, the inherited
document, so I removed that.
6. As far as your project being one of the more active, well, I admittedly
looked at recent updates to pick one. Still, I'm planning on sticking with
your code base, should I update the code, so...

In addition to your changes, I made a few other changes as well, and tested
it out. Primarily, I ran Lint and cleaned up a few things, including
outside of the code I touched, so that's why a whole bunch of files were
touched. I also found a bug in another class, which caused a crash in
Background Handle. I'm not 100% confident of the fix, but it should do for
now...

Ben



On Mon, Dec 30, 2013 at 4:55 PM, Ben Pearson <tuvas21@gmail.com> wrote:

> This change will prevent a crash in the demo app. Warp just crashes
> without it. Looking around, this seemed like the best solution, and it
> works well, but if you have another one, I'm opened to it.
>
> Ben.
>
>
> On Mon, Dec 30, 2013 at 2:35 PM, Jamie Hewland <notifications@github.com>wrote:
>
>> In library/src/com/mobeta/android/dslv/DragSortListView.java:
>>
>> > @@ -640,7 +640,7 @@ public ListAdapter getInputAdapter() {
>> >          }
>> >      }
>> >
>> > -    private class AdapterWrapper implements WrapperListAdapter {
>> > +    private class AdapterWrapper extends BaseAdapter implements WrapperListAdapter {
>>
>> Is there a reason for this change?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/JayH5/drag-sort-listview/pull/1/files#r8590130>
>> .
>>
>
>
>
> --
> Ben Pearson
> http://www.kd7uiy.com
>



-- 
Ben Pearson
http://www.kd7uiy.com