We have a question about this one in particular. We couldn't find the file
common/exti_common_all.h to move things there. Do you want us to create
this file or should we use the file stm32/exti.h and internally use #ifdef
STM32F3 ?

We are also currently working on the other things. Thanks for all this
feedback and time reviewing all this.

All the best,
Federico.
ARCOS-LAB


On Wed, Jan 23, 2013 at 6:48 AM, Karl Palsson <notifications@github.com>wrote:

> In include/libopencm3/stm32/f3/exti.h:
>
> > +
> > +/* --- EXTI registers ------------------------------------------------------ */
> > +
> > +#define EXTI_IMR1			MMIO32(EXTI_BASE + 0x00)
> > +#define EXTI_EMR1			MMIO32(EXTI_BASE + 0x04)
> > +#define EXTI_RTSR1			MMIO32(EXTI_BASE + 0x08)
> > +#define EXTI_FTSR1			MMIO32(EXTI_BASE + 0x0c)
> > +#define EXTI_SWIER1			MMIO32(EXTI_BASE + 0x10)
> > +#define EXTI_PR1			MMIO32(EXTI_BASE + 0x14)
> > +#define EXTI_IMR2			MMIO32(EXTI_BASE + 0x18)
> > +#define EXTI_EMR2			MMIO32(EXTI_BASE + 0x1C)
> > +#define EXTI_RTSR2			MMIO32(EXTI_BASE + 0x20)
> > +#define EXTI_FTSR2			MMIO32(EXTI_BASE + 0x24)
> > +#define EXTI_SWIER2			MMIO32(EXTI_BASE + 0x28)
> > +#define EXTI_PR2			MMIO32(EXTI_BASE + 0x2C)
> > +
>
> hmmm. the existing exti.h should have the registers removed from it, moved
> to common/exti_common_all.h and have the definitions below.
> This is a lot of duplication....
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/libopencm3/libopencm3/pull/82/files#r2741078>.
>
>