If the NewLiferayPluginProjectProfileTests need their own
portalBundlesPaths then they should be moved to the
NewLiferayPluginProject620Tests file instead.


On Wed, Dec 18, 2013 at 11:35 AM, Tao Tao <notifications@github.com> wrote:

> In
> maven/tests/com.liferay.ide.maven.core.tests/src/com/liferay/ide/maven/core/tests/MavenCoreBase.java:
>
> > + *******************************************************************************/
> > +package com.liferay.ide.maven.core.tests;
> > +
> > +import com.liferay.ide.project.core.LiferayProjectCore;
> > +import com.liferay.ide.project.core.tests.ProjectCoreBase;
> > +
> > +import org.eclipse.core.runtime.IPath;
> > +
> > +/**
> > + * @author Tao Tao
> > + */
> > +public abstract class MavenCoreBase extends ProjectCoreBase
> > +{
> > +
> > +    @Override
> > +    protected IPath getLiferayPluginsSdkDir()
>
> I consider the MavenCoreBase as an adapter because I find
> NewLiferayPluginProjectMavenTests and NewLiferayPluginProjectProfileTests
> are sharing the same dependencies, if all portalBundlesPath go into the sub
> classes, we will have duplicate codes. How do you handle the duplicate? And
> the portalBundlesPath in MavenCoreBase can also be overwritten by new sub
> test classes which we would add in the future.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gamerson/liferay-ide/pull/378/files#r8425810>
> .
>



-- 
Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com