I think its fine either way. It just seemed strange that the only thing 
you did to a couple of lines was to change the variable names ^^.

[Maybe the easiest is to adapt the comment?]

On 19.04.2013 11:30, Christopher Smith wrote:
> In sympy/solvers/solvers.py:
>
>>  @@ -2568,18 +2613,18 @@ def _take(d):
>>       elif log(lcm, 2).is_Integer and (not args and len(rterms) == 4 or len(rterms)<  4):
>>           if len(rterms) == 4:
>>               # (r0+r1)**2 - (r2+r3)**2
>>  -            t1, t2, t3, t4 = [t**2 for t in rterms]
>>  -            eq = t1 + t2 + 2*rterms[0]*rterms[1] - \
>>  -                (t3 + t4 + 2*rterms[2]*rterms[3])
>>  +            r0, r1, r2, r3 = [t**2 for t in rterms]
>
> I wanted to renumber and better match the inline comment...how about
>
> |# (r0 + r1)**2 - (r2 + r3)**2
> r0, r1, r2, r3 = rterms
> s0, s1, s2, s3 = [r**2 for r in rterms]
> eq = s0 + s1 + 2*r0*r1 - (s2 + s3 + 2*r2*r3)
> |
>
> or
>
> |def _sqnorm(a, b):
>      return a**2 + b**2 + 2*a*b
> ...
> r1, r2, r3, r4 = rterms
> eq = _sqnorm(r1, r2) - _sqnorm(r3, r4)
> ...
> r1, r2, r3 = rterms
> eq = _sqnorm(r1, r2) - _sqnorm(r3, arg)
> ...
> |
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sympy/sympy/pull/2023/files#r3871191>.
>