This should be done at class level since we don't know at that point
Le 12 août 2013 17:05, "Tarek Ziade" <notifications@github.com> a écrit :

> In circus/commands/util.py:
>
> > @@ -43,14 +43,9 @@ def convert_option(key, val):
> >          return util.to_bool(val)
> >      elif key.startswith('stderr_stream.') or key.startswith('stdout_stream.'):
> >          subkey = key.split('.', 1)[-1]
> > -
> > -        if subkey in ('class', 'filename'):
> > -            return val
> > -        elif subkey in ('max_bytes', 'backup_count'):
> > +        if hasattr(val, 'isdigit') and val.isdigit():
>
> I don't understand this change. If we want an integer, we want to force
> int(xx) here, and make sure we error out on non-digit strings.
>
> So I suggest reverting that change.
>
> cc @Natim <https://github.com/Natim>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla-services/circus/pull/496/files#r5711656>
> .
>