Remove assert that breaks things

The assertion was misplaced, because it should not be fatal in some
circumstances to fail to load the conf file.  For example, in the client
library, having the socket specified either via env or command line
should be the only requirement.  This removes the assert, which in
addition to being wrong also made tests failed with asserts are
enabled.  The author regrets the error.

Signed-off-by: Michael Leibowitz <michael.leibowitz@intel.com>
db/gdbm: Set a dummy label for wire protocol transit

This fixes an assertion that should not be reached when list_keys
does not have a label set for each BuxtonData.

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
db/gdbm: Ensure transit length includes null terminator

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
Link gdbm.so to libbuxton

As counter intuitive as this may seem, gdbm currently needs access
to libbuxton specific functionality, namely buxton_get_name to split
a key's name from the key:group identifier.

In the near future the present make system will be modified to remove
cross-linking between existing components, and shared accessors such
as buxton_get_name will be split into a static library.

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
configurator: Use const char* for internal members

The strings returned by the public configurator methods are owned
by configurator itself, and should not be modified or free'd by
any external API.

This commit makes this requirement clearer by forcing the use of
const char* for returned strings,

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
cli: Free label after running get-value

This commit fixes a memory leak where the value is not free'd when
a successful get_value operation takes place.

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
Calculate and display error count.

We want to keep the tests running even if there are occasional
errors to have an idea how the server handles possible error
tests. Count the errors and display in the output for each
run.
This can be static.
array: Use greedy_realloc to ensure alignment and speed

Signed-off-by: Michael Ikey Doherty <michael.i.doherty@intel.com>
db: Use internal get_name api

Signed-off-by: William Douglas <william.douglas@intel.com>
Fix leak and related double-free

William was nice enough to stop by and point out how foolish I was to
have set the initialized flag to false, but failed to set it to true.
This was embarrassing.  To make matters worse, I managed to violate the
terms of the API in my tests and free the pointer that I was told not
to.  This of course, causes a double-free failure.

This change rectifies both problems and serves as the public shaming
that I so duly deserve.

Signed-off-by: Michael Leibowitz <michael.leibowitz@intel.com>
Make check errors out if you don't configure with --enable-debug

This is somewhat of an irritation and a little hackish, but there isn't
really a better way.  This also makes make distcheck use
--enable-debug.  This is one more thing to help developers avoid
mistakes, hopefully.

Signed-off-by: Michael Leibowitz <michael.leibowitz@intel.com>
shared: Free layers on direct close

Signed-off-by: William Douglas <william.douglas@intel.com>
shared: Remove unneeded hashmap

_directPermitted is obsolete with only the daemon and buxtonctl direct
able to use it.
Add warn_unused_result attribute

Include warnings to exported functions for when their return values
are unused and fix and warnings that showed up.

Signed-off-by: William Douglas <william.douglas@intel.com>