I think it could go in Trello with other technical debt.

However, I'm not sure it would be worth the bother, in a language like
Java, of dealing with all the type conversions between String and
BCP47LanguageCode.  Any time we deal in languages (except on the very
edges of the system, dealing with the outside world), the Strings should
be BCP47.  If we stick to that rule, it should be pretty simple.

On 2013-07-29 16:26, David Mason wrote:
> In
> zanata-model/src/main/java/org/zanata/model/tm/TransMemoryUnitVariant.java:
> 
>> + */
>> +@Entity
>> +@EqualsAndHashCode(callSuper=true, exclude = {"content"})
>> +@ToString(exclude = {"contentHash", "metadata"})
>> +@NoArgsConstructor
>> +@Data
>> +@Access(AccessType.FIELD)
>> +@ClassBridge(impl = TransUnitVariantClassBridge.class)
>> +@AnalyzerDiscriminator(impl = TextContainerAnalyzerDiscriminator.class)
>> +public class TransMemoryUnitVariant extends ModelEntityBase implements HasTMMetadata
>> +{
>> +   private static final long serialVersionUID = 1L;
>> +
>> +   // This is the BCP-47 language code
>> +   @Column(nullable = false)
>> +   private String language;
> 
> I agree. I'll add it to my personal list of things that need
> refactoring. Would it be worth making such a list for the team, or
> adding a note in the code somewhere?
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/78/files#r5443548>.
> 


-- 
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat