It is called by the Interpreter,but the class MaybeRedirectOutput is private so it should not be able to b called from outside the Interpreter.
________________________________________
From: karies [notifications@github.com]
Sent: 17 December 2013 15:09
To: karies/root
Cc: Bianca-Cristina Cristescu
Subject: Re: [root] Redirect (#38)

In interpreter/cling/include/cling/Interpreter/Interpreter.h:

> +      kSTDOUT,
> +      kSTDERR,
> +      kSTDBOTH
> +    };
> +
> +  private:
> +    class MaybeRedirectOutputRAII {
> +    private:
> +      Interpreter* m_Interpreter;
> +      char *terminalOut;
> +      char *terminalErr;
> +
> +    public:
> +      MaybeRedirectOutputRAII(Interpreter* i);
> +      ~MaybeRedirectOutputRAII() { pop(); }
> +      void pop();


If this is public you expect people to call it in certain circumstances. Is that the case? Is this handled? Else just make it private.

—
Reply to this email directly or view it on GitHub<https://github.com/karies/root/pull/38/files#r8402389>.