should this also be prop instead of attr?