Revert "Bug 9951: Followup for tools/viewlog.pl"

This reverts commit de7ba790fd2533bcf44ad7fd2f1255514ed9313c.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 9951: Followup for Tools"

This reverts commit 252568aa8babdcc9508d3b3c7626543bfa648d99.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 10019: Fix for userid containing UTF8 chars"

This reverts commit 7e90e1524f7e586dac0f98241ace430e5cbeac7f.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 10074: QA Followup for InstallAuth.pm"

This reverts commit e848d89e45d3e6610c3e9d246bd3672636dd63fb.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 10074 - Encoding problems for installer"

This reverts commit d0c6e09429d2af711f911b57601a02f17591d441.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 10074 - Encoding problems at login time"

This reverts commit 5805b5f363bd657d3dac6aeba225438bf80cae9b.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554 Fix error caused by modifying $_ in a map"

This reverts commit e98fe7e32244fa11d218b4d2a1006eea547e70d8.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554 - make Koha internally utf-8 clean"

This reverts commit d542740ab8877234d043c8a11cb19a6004e72656.

Rolling back bug 6554 work until we have more comprehensive tests.

Conflicts:

	opac/opac-search.pl
Revert "Bug 6554 QA Followup"

This reverts commit 686fdae32c2377b8748f71c534b5f32a2a83e850.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554: Followup for serial search"

This reverts commit c18cd930eb3d15e20c642b2788116cc2abb30538.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554: Followup for acquisitions"

This reverts commit b2b003adea685acf3f590ed00baf7abec734341f.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554: Followup for preferences.pl"

This reverts commit c78b905811ed4869a4a69f60272e1b7787026f6e.

Rolling back bug 6554 work until we have more comprehensive tests.
Revert "Bug 6554 Followup for circulation patron search"

This reverts commit f257944d10c2660e7d7297768af314985c80a1c7.

Rolling back bug 6554 work until we have more comprehensive tests.
Merge remote branch 'origin/new/bug6554_reverts'
Bug 10149 - koha-restart-zebra error handling (rewording)

koha-restart-zebra now
- Checks the instance exists.
- Checks the instance is enabled.
- Checks if the zebra daemon is already running.

Regards
To+

Edit:
- changed some wording problems.
- fixed an error in parameter validation

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Bug 10144 - koha-start-zebra error handling

koha-start-zebra now
- Checks the instance exists.
- Checks the instance is enabled.
- Checks if the zebra daemon is already running.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Bug 10104 - make koha-disable more robust

koha-disable now:

- checks for the existence of the instance before any actions on it.
- checks if the instance is already disabled before touching anything (warns otherwise)
- only reloads apache if needed
- handles more than one instance name.
- changed the docs to acknowledge the previous item.

To test:
- Apply the patch, build your package
- Run koha-disable on
  - Non existent instance (try names that are prefix and suffix of a valid one too please)
  - Already disabled instance name.
  - Enabled instance name.

It should work as expected and warn the user on the expected wrong cases.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Bug 10104 - Followup: fix param check

As noted by Mason on bug 10101, the check was not working for zero arguments.

Sponsored-by: Universidad Nacional de Córdoba

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Bug 10101 - make koha-enable more robust

koha-enable now:

- checks for the existence of the instance before any other action on it.
- checks if the instance is already enabled before changing stuff in the config files.
- only reloads apache if it is needed!
- handles more than one instance name as parameter (the code was there, a check for the cardinality of the args prevented it from working).
- documents this behaviour change in the docs
- doesn't break if the provided (invalid) instance name is a prefix/suffix of a real one (added -x to the relevant grep command).

To test:
- Aplpy the patch, build your packages
- Run koha-enable on
  - Non existent instance (try using a prefix or a suffix of an already created one too).
  - Already enabled existent instance name.
  - Disabled instance.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Bug 10101 - Follwup: fix param check

As Mason noted, there was an error on that line.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>