cool, updated. 

----- Original Message -----

From: "Nan Liu" <notifications@github.com> 
To: "vmware/vmware-vcenter" <vmware-vcenter@noreply.github.com> 
Cc: "sholland" <sholland@vmware.com> 
Sent: Wednesday, April 10, 2013 6:38:44 PM 
Subject: Re: [vmware-vcenter] added vc_vpxsettings type / provider (#88) 



In lib/puppet/type/vc_vpxsettings.rb: 
> +
> +                 vpx_settings => { 'event.maxAge' => 14, 'event.maxAgeEnabled' => true, }
> +
> +         "
> +    validate do |value|
> +      value.each do |k,v|
> +        if k =~ /enabled$/i
> +          fail("value: #{v} must match true/false") if v.to_s !~ /^(false|true)$/
> +        else
> +          fail("value: #{v} must match valid word character") if v.to_s !~ /\w/
> +        end
> +      end
> +    end
> +  end
> +
> +  #autorequire(:vc_folder) do 


I think you are fine since it still merges cleanly. Just squash and we can merge. 

— 
Reply to this email directly or view it on GitHub .