I'd like the old behavior, but with a LOG.warn if
!mTableURI.equals(other.getURI()), since it probably represents a
logical error in our code paths.

On Mon, Jan 21, 2013 at 12:25 AM, Lee <notifications@github.com> wrote:
>
> In kiji-schema/src/main/java/org/kiji/schema/impl/AbstractKijiTable.java:
>
> > @@ -128,20 +114,17 @@ public boolean equals(Object obj) {
> >      }
> >      final KijiTable other = (KijiTable) obj;
> >
> > -    // TODO Check that those are referring to the same HBase instance.
> > -    // Equal if the kiji instance name and the table name are the same.
> > -    return getKiji().getName().equals(other.getKiji().getName())
> > -        && getName().equals(other.getName());
> > +    // Equal if the two tables have the same URI:
> > +    return mTableURI.equals(other.getURI());
>
> I'm a little worried about using comparing the raw URI strings, since they could have column names within. From a quick check of our code, I don't think this is currently an issue, but we may want to adjust the javadoc.
>
> —
> Reply to this email directly or view it on GitHub.