LU-3097 build: fix 'stray semicolon' errors

Fix 'stray semicolon' issues found by Coverity version 6.5.1:
Stray semicolon (STRAY_SEMICOLON)
"if" statement with no "then" or "else" is suspicious.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: Ieff4b45204f8be9ad4590cc9de9d06960c07d052
Reviewed-on: http://review.whamcloud.com/7165
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-3097 build: fix 'deadcode' errors

Fix 'deadcode' issues found by Coverity version 6.5.1:
Logically dead code (DEADCODE)
Execution cannot reach this statement.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Change-Id: I720a5ae6f963cd2cc77208a854ca4587758a82d5
Reviewed-on: http://review.whamcloud.com/7167
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
LU-3069 build: fix 'integer handling' issues

Fix 'program hangs' defects found by Coverity version 6.5.1:
Improper use of negative value (NEGATIVE_RETURNS)
Variable is passed to a parameter that cannot be negative.
Macro compares unsigned to 0 (NO_EFFECT)
This comparison is always true.
Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
Test is always false regardless of the values of its operands.
Wrong operator used (CONSTANT_EXPRESSION_RESULT)
Test is always true regardless of the values of its operand.

Signed-off-by: Sebastien Buisson <sebastien.buisson@bull.net>
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I687a05aaffad13caaebe16edbc4f93ef7ca3413f
Reviewed-on: http://review.whamcloud.com/5888
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
New tag 2.4.90

Change-Id: Iccc12581222bf19c71464c1df06e3f5fe21ee596
LU-1346 libcfs: cleanup macros in kp30.h

Some macro cleanup in kp30.h

Some other changes:
. removes some unused/reduplicate macros such as
our_recalc_sigpending, prepare_work, cfs_get_work_data, strtok,
work_struct_t, SEM_COUNT, PORTAL_SYMBOL_REGISTER/UNREGISTER,
cfs_num_present_cpus, cfs_num_present_cpus
. moves some different kernel version compatible macros/inlines to
  portals_compat25.h
. needs not differentiate CONFIG_SMP for LASSERT_SPIN_LOCKED
. get/put_cpu is avaiable for both SMP and !SMP

This patch does not change LWT(Light-weight trace) related code.

Signed-off-by: Liu Xuezhao <xuezhao.liu@emc.com>
Signed-off-by: Peng Tao <tao.peng@emc.com>
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Change-Id: Iaa3cda88d539f3d7e677b7accda99b476daeddca
Reviewed-on: http://review.whamcloud.com/4776
Reviewed-by: Keith Mannthey <keith.mannthey@intel.com>
Tested-by: Hudson
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Yang Sheng <yang.sheng@intel.com>
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>