data generation now working