The few lines after the else are executed and are necessary. I stepped
through it with the debugger. I don't know about the break in the for
requirement, but the code does get executed.

On 13-09-26 03:06 PM, Adrian Sampson wrote:
>
> In beetsplug/lastgenre/__init__.py:
>
> >      for genre in list(genres):
> >          if _is_allowed(genre):
> > -            return genre.title()  # Title case.
> > -    return None
> > +            allowed_genres.append(genre.title())
> > +
> > +#    pdb.set_trace()
> > +
> > +    for genre in allowed_genres[:-1]:
> > +        genre = genre + ', '
> > +        allowed_genres_copy.append(genre)
> > +    else:
>
> This |else| block never executes because the |for| body doesn't have a
> |break| in it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sampsyo/beets/pull/397/files#r6610906>.
>