landscape.py : fix old format in cmd
ldap.py : remove unneeded def setup
fix small misses following refactoring
ldap.py : improved data collection on Ubuntu/Debian
Merge pull request #136 from karibou/master

Minor fixes and reformat
Merge branch 'new_ldap' of https://github.com/karibou/sosreport

Conflicts:
	sos/plugins/ldap.py
Fix scoping bug in kernel.py

The path "/sys/module" was made into a class variable to avoid
repeating the string through the file. Make sure all uses qualify
the variable appropriately.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Clean up SoSReport.execute()

Reorganise the SoSReport object's execute() method to facilitate
separation of the command line and report generation logic:

 - Rename ensure_plugins() as verify_plugins() and have it return
   a boolean to the execute() method.

 - Push logging down from execute into the individual action
   methods that carry out the tasks being logged.

 - Have execute() return a boolean indicating whether the
   requested operation completed successfully or not.

Longer term it may be better to define an enumeration class for
sos return statuses. This would allow more expression than simple
'pass' or 'fail' and would help the move toward an API.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Rename listPlugins to list_plugins

Rename the option variable listPlugins to list_plugins to conform
with pep8 and other uses in the options set.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Move command line parsing out of SoSReport class

Separate the command line logic from the rest of the SoSReport
class and add a new SoSOptions class to contain it.

SoSOptions may either be initialised from a command line by
passing in an argument list to the initializer or by creating
an empty object and setting values for individual properties.

For now a SoSOptions object is initialized in the SoSReport
initializer (from the argument list passed from __main__).
Eventually this will move into __main__ allowing SoSOptions and
SoSReport to become an interface for external users.

The next step is to move all input validation into the SoSOptions
class (it's currently spread around the code that uses the
options).

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Fix scoping bug in named.py

The path "/etc/named.conf" was made into a class variable to avoid
repeating the string through the file. Make sure all uses qualify
the variable appropriately.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>