I'm correcting all of the things you mentioned.  A couple of notes:

With the exception of the member variables in DisableableComboBox, the
default accesses are intentional.  I'm using these to indicate methods and
classes that I want to be able to call from within the ModelingCommons
package, but I don't want publicly available.  I'm trying to make methods
that could potentially be used outside of the package public and everything
that I want public only within the package (for my own use) package-private
(default).

In src/main/org/nlogo/modelingcommons/DisableableComboBox.java:

> +import java.awt.event.ActionListener;
> +import java.util.ArrayList;
> +import java.util.List;
> +
> +/**
> + * Created with IntelliJ IDEA.
> + * User: Ben
> + * Date: 11/28/12
> + * Time: 12:06 PM
> + * To change this template use File | Settings | File Templates.
> + */
> +public class DisableableComboBox extends JComboBox {
> +  private class Item {
> +    Object obj;
> +    boolean enabled;
> +    public Item(Object obj, boolean enabled) {

Generics in JComboBox weren't added until Java 7, so I'm just going with
what Java does.


Thanks,

Ben Rafshoon


On Tue, Feb 5, 2013 at 2:52 PM, Jason Bertsche <notifications@github.com>wrote:

> In src/main/org/nlogo/modelingcommons/LoginDialog.java:
>
> > +import java.awt.event.WindowAdapter;
> > +import java.awt.event.WindowEvent;
> > +import java.util.Arrays;
> > +
> > +public class LoginDialog extends JDialog {
> > +  private JPanel contentPane;
> > +  private JButton cancelButton;
> > +  private JButton loginButton;
> > +  private JPasswordField passwordField;
> > +  private JTextField emailField;
> > +  private JLabel errorLabel;
> > +  private JButton createAccountButton;
> > +  private Frame frame;
> > +  private ModelingCommons communicator;
> > +
> > +  LoginDialog(Frame frame, final ModelingCommons communicator, String errorLabelText) {
>
> Default access
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NetLogo/NetLogo/pull/281/files#r2900157>.
>
>