Looks fine to me!

On Jul 8, 2013, at 10:12 PM, Joshua Peek <notifications@github.com> wrote:

> In activesupport/lib/active_support/message_verifier.rb:
> 
> >        else
> >          raise InvalidSignature
> >        end
> >      end
> >  
> > -    def generate(value)
> > -      data = ::Base64.strict_encode64(@serializer.dump(value))
> > -      "#{data}--#{generate_digest(data)}"
> > +    def generate(value, options = {})
> > +      if options[:expires]
> > +        data = ::Base64.strict_encode64(@serializer.dump([value, options[:expires].to_i]))
> > +        "#{data}-@#{generate_digest(data)}"
> 
> Inventing a new separator format here. Makes it possible to tell the different between permanent and perishable messages.
> 
> Is -@ aesthetically pleasing?
> 
> —
> Reply to this email directly or view it on GitHub.
>