(maint) make SRV record lookup more generic
(#21785) Module tool should include path part of URI

The module tool ignored the path part of the URI when specifying a
custom module_repository setting.

Example:
puppet module install foo-bar --module_repository=‘http://forge.example.com/forge’

fetched http://forge.example.com/api/v1/releases.json?module=foo/bar
instead of
http://forge.example.com/forge/api/v1/releases.json?module=foo/bar

Same issue when it tries to fetch the file itself.
(doc) Clarify a couple of comments under lib/puppet/

- 'should not be used in preference to' as 'should be avoided in favor of'
- '25K to 300 symbols to strings' as '25K symbols vs. 300 strings'
(maint) Various fixes (whitespace, etc)
(maint) Spelling fixes for code comments

'acutal' to 'actual'
'allowal' to 'allowable'
'cahe' to 'cache'
'corrosponding' to 'corresponding'
'dafault' to 'default'
'defauls' to 'defaults'
'defualts' to 'defaults'
'follwing' to 'following'
'manageing' to 'managing'
'managhome' to 'managehome'
'matchin' to 'matching'
'pupet' to 'puppet'
'repositry' to 'repository'
'terminii' to 'termini' (per Oxford, 'termini' or 'terminuses')
'ths' to 'this'
(maint) Typo fixes for code comments
Merge pull request #1801 from floatingatoll/patch-3

various documentation fixes
Enhance OpenBSD pkg.conf handling

This moves the pkg.conf parsing into it's own method which allows for better
re-use. While here, support for parsing '+=' lines has been added. This allows
for appending to PKG_PATH, instead of merely setting it with '='.

(#21930) Enchance OpenBSD pkg.conf handling
(maint) Remove rspec requires from the Rakefile

In the Rakefile, we no longer use Rspec methods or classes, but instead shell
out to rspec, so requiring rspec serves no purpose in the rakefile. The require
was also incorrectly placed within an unrelated begin/rescue block, which
caused deprecated rake libraries to be loaded when rspec was not present. This
commit removes it from the Rakefile.
Merge pull request #1814 from haus/maint/stable/move_rspec_requires

Remove rspec requires from Rakefile
(#21970) Comment fixup

The REST certificate endpoint supports only find, not save.
(#21970) Move supported formats into the per-endpoint md
(#21970) Add markdown doc for certificate endpoint

Add markdown doc and add link from index markdown page.
(#14333) Ensure module permissions are sane.

Prior to this change, tarballs unpacked by the root user would be unpacked
with the permissions and the ownership information present in the tarball.
In the best case, this made some modules fail to function after installation
since the newly installed module was owned by a different user. In the worst
case, this could be seen as a fairly serious security vulnerability.

This change ensures that the module's permissions are always owner-writable,
world-readable, and that the owner is always the same as the module's parent
directory.
Backporting acceptance tests.
Merge pull request #1815 from pvande/PF-166-2.7.x

(#14333) Ensure module permissions are sane – 2.7.x backport.
(22023) Implement :purgeable feature for OpenBSD package provider
Encode the path passed to json-schema as a URI

Json-schema expects a URI and fails if given a path with unencoded spaces.
Docs: Slight tweak to description of the alias metaparameter

- Delete the link to the old language guide; there's no "more information" in there.
- Explain effects in practical terms instead of expecting the reader to know the
  diff between the parser and the "library."
- Adjust quoting.
- Fix technically-correct-but-not-what-we-were-trying-to-show syntax.
Revert "Encode the path passed to json-schema as a URI"

This reverts commit 5c097f9e0b89debc3923b4cfeba0730a68cfb210.