Agreed. This should be handled by a path concat function. The java.nio.file
Path class could it but that requires java 7.  Is java backward
compatibility a must?


On Tue, Jul 30, 2013 at 6:44 PM, Nathan Marz <notifications@github.com>wrote:

> In src/clj/backtype/storm/testing.clj:
>
> > @@ -32,7 +32,7 @@
> >    (FeederSpout. (Fields. fields)))
> >
> >  (defn local-temp-path []
> > -  (str (System/getProperty "java.io.tmpdir") "/" (uuid)))
> > +  (str (System/getProperty "java.io.tmpdir") (if-not on-windows? "/") (uuid)))
>
> If it's on windows is the path separator already there?
>
> Probably the best thing to do here is factor out a concat-paths function
> which explicitly handles / and \ appropriately, this seems hacky.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nathanmarz/storm/pull/603/files#r5494070>
> .
>