core: CommonPoolWithVms.isVmPoolNameValidLength

Patch 540a75e0f7bc4b9ed879471d3d830d575c6d6060 removed the last usage of
CommonVmsPoolWithVmsCommand.isVmPoolNameValidLength(String), so now this
method should be removed too.

Instead, use VmCommand.isVmNameValidLength(VM).

Change-Id: Ide5f59bf24cf2562a0cd69f97bc4224a4660e556
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove mockStorageGuidList

CommonVmPoolWithVmsCommandTestAbstract.mockStorageGuidList(List<StorageDomain>)
is unused and should thus be removed.

Change-Id: I40b6f7514349a2f9888871a4a1301669332ae373
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Rm GetDiskAlignmentCommand.serialVersionUUID

Since commands are no longer Serializable, there is not point in having
a serivalVersionUUID in GetDiskAlignmentCommand.

Change-Id: I96eea341ec3ee054972da41aa1029d398ca8d390
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: GetDiskAlignmentCommand.getStorageDomainDao

Removed the unused GetDiskAlignmentCommand.getStorageDomainDao()
method.

Change-Id: I4f2879420a5bc268660d91412bde104a0b70d4dc
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: remove HandlersFactory.createVmPoolHandler

Remove unused method.

Change-Id: I5033305edcf4bc1b18ef69596b9079d0ad080a61
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove unused QueryData.type property

This property is saved in the object but never used afterwards,
therefore it's redundant and should be removed.

This patch removes the property, its getter, and the constructor
argument that initializes it.

Change-Id: I4b6cb8d9d94862fc2b66fdb1031835c4ed222f2a
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: rm RemoveVmHibernationVolumeCommand consts

Removed constants that were migrated to VmCommand and left here by
mistake.

Change-Id: I375c632bae106683d783b5e7b081a00c83ac34f5
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove unused TagsHandler methods

Change-Id: I01e44ce5e7f71f8c2c32d1dbf8969e8c50824966
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove unused empty method in VdsHandler

Change-Id: Iad3736231a24947f896169eace0758bc8d1048a8
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: rm VmTemplateHandler.MarkVmTemplateAsIllegal

This method was unused and should thus be removed.

Change-Id: I50680cfe4b0e9dfe908f95f0297ee38cdd1ea83e
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: rm unused class WindowsErrorsTranslationMap

Change-Id: If2a185c9c5154427cd50231141a3c38585dfaf0e
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove unused interface Scorable

Change-Id: Iee297de0bdd2c07ff784acc2bd5b32e59da2435c
Signed-off-by: Allon Mureinik <amureini@redhat.com>