[z2270] Make Spell 18172 as Debuff close #11 Thanks Ghurok

This Spell is needed for Quest "Kodo Roundup" (5561).

Signed-off-by: Salja <salja2012@hotmail.de>
[z2271] Some small changes

* Replace Expansion related magic numbers
* Remove an unneeded double line. Thanks to Ambal for pointing
* Add additional check for DK starting zones map file

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12364] - 90e787f)

(based on commit [s1897] - acc883d)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
Remove another redundant InBattleGround() check

(based on commit 0055d05)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit 4b852f3)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2272] fix Singleton compile error on clang

some members of Singleton were implicitly specialized in the static function
definitions, which conflicted with the initialization of said members (clang
saw it as a redefinition of the specialization)

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12365] - 772a5bb)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1898] - 8416722)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2273] fix clang compile error from implicit type conversion

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12366] - ce05512)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1899] - 31eb066)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2274] fix clang compile error from call of templated member function

Signed-off-by: DasBlub <DasBlub@gmail.com>

(based on commit [12367] - 4a407cc)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1900] - ecbe152)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2275] Cleanup battleground code

Signed-off-by: Carl Hjerpe <lillecarl@gmail.com>

(based on commit 4814020)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1901] - 70ddd52)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2276] Remove shapeshift forced object update hack

This and 8046e0e properly fixes powershifting

(based on commit 375b139)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1902] - a443260)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2277] Hack TBB code for support VS2012 (and new C++ standard in fact)

This hack will need until TBB will not support VS2012 by self.
With big chance with next TBB update in repo we can safely drop this
hack.

(based on commit [12368] - 7e9e22e)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1903] - 72346d1)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2278] Add support for VS2012 building.

[ci skip] for make travis happy ;)

(based on commit 3c73ecc)
(based on commit 6f97021)
(based on commit 3c9fca4)

(based on commit 1300724)
[z2279] Use recently introduced performance timer for additional state updates

This should give a slight performance improvement without visibly disadvantage for players.
Maybe someone is willing to test 200 as default check intervall, how this scales
[ci skip] (mostly rename :P )

(based on commit [12372] - 232f3fa)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1906] - f5163cb)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2280] Don't send Spell::CheckCast fail result for passive auras

No need to notify client when a passive aura failed to cast (like using Cat Form indoor with Feral Swiftness talent learned).

Contributor Maxxie.

(based on commit [12373] - 66d4653)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1907] - b6acea3)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2281] Fix compiler warning about initialization order

Fix warning: '<class>::<member>' will be initialized after <class>::<member>" (Linux/GCC).

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12374] - 7f6f284)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1908] - fa49c45)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2282] Fix some signed/unsigned integer comparison warnings

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12375] - 1ba4ddb)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1909] - 3bc8931)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2283] Fix CMake ExternalProject_Add command for ACE on UNIX systems

(based on commit [12379] - 8cfd615)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s1911] - bc9a398)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2284] Looks for passive auras that need to be recast. Like talent spell Feral Swiftness (id: 17002 and ranks), once you go inside a building and then outside again.

Contributor : Ebrithil
[z2285] Re-sync realmd code in mangos-classic with mangos-tbc

Fixed possible crash at wrong realmd name in DB

Realmd sources mustbe _exactly_ same in classic/tbc/wotlk.

(based on commit 2582ca8)
[z2286] Fix recently un-outcommented code to be actually working
[z2287] Use Filter log for grid unloading messages
[z2288] Note ingame if gossip conditions are ignored because of GM mode