started adding model_trait