I'll change the obsolete and make it throw

Sent from my iPhone

> On 23 nov 2013, at 01:54, Simon Cropp <notifications@github.com> wrote:
> 
> In src/NServiceBus.Core/MessageHeaders/MessageHeaderManager.cs:
> 
> >  
> >      /// <summary>
> >      /// Message Header Manager
> >      /// </summary>
> > +    [ObsoleteEx(RemoveInVersion = "5.0",TreatAsErrorFromVersion = "5.0")]
> >      public class MessageHeaderManager : IMutateOutgoingTransportMessages
> this is actually the worst way to obsolete something. If people are using this class you have broken it in a way that means it will seem to work at runtime while actually not performing the behavior they expect. It will alos only throw a warning at compile time.
> 
> Better to either
> 
> remove it and document it. so it fails at compile time and runtime
> make it as obsolete with error in the current version number and throw a helpful exception from the MutateOutgoing
> —
> Reply to this email directly or view it on GitHub.