Made the updates as per review except for limit on corelations. I will add that in later or tune the plotting depending on our typical usage of the correlation.



From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, November 5, 2013 9:15 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Sharad Gandhi <sgandhi@linkedin.com<mailto:sgandhi@linkedin.com>>
Subject: Re: [naarad] Added support for co-relation using matplotlib (#5)


In src/naarad/graphing/matplotlib_naarad.py:

> +        current_axis.axis['right'].toggle(all=True)
> +      current_axis.set_ylabel(plot.graph_title + '(' + plot.y_label + ')', color=get_current_color(current_plot_count))
> +      if plot.graph_type == 'line':
> +        current_axis.plot_date(x=timestamp, y=yval, linestyle='-', marker=None, color=get_current_color(current_plot_count))
> +      else:
> +        current_axis.plot_date(x=timestamp, y=yval, linestyle=None, marker='.', color=get_current_color(current_plot_count))
> +  if plots_in_error == plot_count:
> +    return False, None
> +  plt.title(graph_title)
> +  plt.xlabel('Time')
> +  plt.grid(True)
> +  plt.setp(current_axis.xaxis.get_majorticklabels(), rotation=20)
> +  plot_file_name = os.path.join(output_directory, output_filename + ".png")
> +  fig.savefig(plot_file_name)
> +  plt.close()
> +  return True,None


What about the html?

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/5/files#r7437551>.