oops i should really add tests