Nice work Zsolt. I'll leave it up to Justin to comment on the standard
we've adopted in the DSL for things like this. Ill make sure we document it
more clearly on the wiki afterwards too to help future contributors.
On 31 Mar 2013 10:44, "Zsolt Takács" <notifications@github.com> wrote:

> In
> job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextHelper.groovy:
>
> > @@ -558,6 +558,31 @@ class PublisherContextHelper extends AbstractContextHelper<PublisherContextHelpe
> >              }
> >              publisherNodes << publishNode
> >          }
> > +
> > +        def irc(Closure ircClosure = null) {
> > +            IrcContext ircContext = new IrcContext()
> > +            AbstractContextHelper.executeInContext(ircClosure, ircContext)
>
> I've removed the default null, but I don't think we should check anything.
> If the closure is empty then the defaults will be used without any channels
> added, and it will be a valid config.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/job-dsl-plugin/pull/46/files#r3596345>
> .
>