I fixed this and rebased my commits.

I check in the NumPy c code and it set an error. Also, you added generic
check for that, so I don't think a specific check for that is needed.


On Tue, Oct 15, 2013 at 11:33 AM, Pascal Lamblin
<notifications@github.com>wrote:

> In theano/tensor/basic.py:
>
> > @@ -3887,9 +3887,10 @@ def c_code(self, node, name, inputs, outputs, sub):
> >                  PyArray_CORDER);
> >              if (!%(z)s)
> >              {
> > -                PyErr_Format(PyExc_ValueError,
> > -                             "Could not reshape array.");
> > -                %(fail)s;
> > +                //The error message should have been set by PyArray_Newshape
> > +                //PyErr_Format(PyExc_ValueError,
> > +                //             "Could not reshape array.");
> > +                %(ifail)s;
>
> ifail? typo?
> Also, can you check if there is indeed an error set, and if not, set it?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Theano/Theano/pull/1562/files#r6974443>
> .
>