I'll change it.  How do you deal with this changes after the pull request?
 Will you reject the pull and then have me change, push, and re
peat the pull request?


On Tue, Aug 27, 2013 at 3:40 PM, Jeremy Fee <notifications@github.com>wrote:

> In src/lib/classes/ObservatoryDetail.class.php:
>
> > +		$this->observations = $observations;
> > +		$this->piers = $piers;
> > +	}
> > +	
> > +	public static function fromArray(&$p) {
> > +		
> > +		$instruments = array();
> > +		$observations = array();
> > +		$piers = array();
> > +		
> > +		if (isset($p['instruments'])) {
> > +			foreach ( $p['instruments'] as $instrument ) {
> > +				$instruments[] = Instrument::fromArray($instrument);
> > +			}
> > +		}
> > +		else if (isset($p['observations'])) {
>
> This should be an "if" instead of "else if", you always want to load
> observations when present
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/usgs/geomag-baseline-calculator/pull/28/files#r6019272>
> .
>