no you can commit on your branch and the PR is updated!


On Fri, Jul 19, 2013 at 3:10 PM, Marius Soutier <notifications@github.com>wrote:

> In
> framework/src/play-json/src/main/scala/play/api/libs/json/JsConstraints.scala:
>
> > @@ -112,11 +112,19 @@ trait ConstraintReads {
> >    def seq[A](implicit reads: Reads[A]): Reads[Seq[A]] = Reads.traversableReads[Seq, A]
> >    def map[A](implicit reads: Reads[A]): Reads[collection.immutable.Map[String, A]] = Reads.mapReads[A]
> >
> > -  def min(m: Int)(implicit reads: Reads[Int]) =
> > -    filterNot[Int](ValidationError("error.min", m))(_ < m)(reads)
> > +  /**
> > +   * Defines a minimum size for a numeric Reads. Combine with `max` using `or`, e.g.
>
> Yes you're right... I guess I have to close this PR and submit a new one?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/playframework/playframework/pull/1363/files#r5291461>
> .
>