working on all_key