You are right about the return, I caught that later but did not get it
checked in. There are some differences across jq versions with whether a
string or xml dom is returned from the ajax xhr object, so it will only
affect certain users.

I am fine with setting the version number to whatever you like. I just
incremented so that it would be obvious at a glance that the file had been
changed.
On Mar 30, 2013 2:43 AM, "Remy Blom" <notifications@github.com> wrote:

> In jquery.soap.js:
>
> > @@ -319,6 +387,37 @@ All code below this point is proton17's
> >  		};
> >  	};
> >
> > +	//Soap response - this will be passed to the callback from SOAPClient.SendRequest
> > +	var SOAPResponse=function(status, xhr) {
> > +		this.typeOf="SOAPResponse";
> > +		this.status=status;
> > +		this.headers=xhr.getAllResponseHeaders().split('\n');
> > +		this.httpCode=xhr.status;
> > +		this.httpText=xhr.statusText;
> > +		this.content=null;
> > +		this.toString=function(){
> > +			if (typeof this.content==='string') {
> > +				return this.content;
> > +			}
> > +			if ($.isXMLDoc(this.content)) {
> > +				SOAPTool.dom2string(this.content);
>
> Should this not include a return?? Like:
>
> return SOAPTool.dom2string(this.content);
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/doedje/jquery.soap/pull/3/files#r3594203>
> .
>