SotBE S6: fix typo in variable names
Fixed wmllint with my latest commits
wmllint: Recognize help_topic_text as a translatable attribute

The attribute is used in [terrain_type] and it was first implemented in
a28cfc3fd96264c411453307d536b48435e5bdeb.
Fixed the FIRE_BURST_SMALL macro only showing the last frame
Revert "Fixed the FIRE_BURST_SMALL macro only showing the last frame"
It seems to be c++ related, and not in the WML, and therefore the commit wasn't really a solution

This reverts commit 22dd990a45b77b853935d87646e550c5288a7d48.
fixed compilation be referencing the correct file
scons: Fix test suite linking step after the hotkey refactoring changes

1b1de2e720205e9cc729b34a6513418ab654ccb9 adds a few files in replacement
of src/hotkeys.cpp and this somehow broke the test suite target's
linking step resulting in the following errors:

  game_config_manager.cpp:(.text._ZN10test_utils19game_config_managerC2Ev[_ZN10test_utils19game_config_managerC5Ev]+0x4b): undefined reference to `hotkey::manager::manager()'
  game_config_manager.cpp:(.text._ZN10test_utils19game_config_managerC2Ev[_ZN10test_utils19game_config_managerC5Ev]+0x631): undefined reference to `hotkey::manager::~manager()'
  collect2: error: ld returned 1 exit status

This is apparently a linking order issue, since those symbols actually
exist in the object set linked into the test suite executable.

After some fiddling around I discovered that changing the test suite
linking order as follows appears to fix the issue:

Before: libwesnoth_extras.a lua/liblua.a libwesnoth_core.a libwesnoth_sdl.a libwesnoth.a libwesnoth_extras.a lua/liblua.a libtest_utils.a

Now: libtest_utils.a libwesnoth_extras.a lua/liblua.a libwesnoth_core.a libwesnoth_sdl.a libwesnoth.a

The most obvious change is that libtest_utils.a is now linked first.
Additionally, libwesnoth_extras.a and liblua.a are only linked once at
the start. The duplicated entries were introduced in commit
b08bb2e9b1a82d25dede45bf57f8ba73c62e50de, but I couldn't really find an
issue with deduplicating them (tested with clang 3.2 and gcc 4.8).

I am not really sure what's going on, but loonycyborg told me to commit
the fix anyway. If Wesnoth spontaneously ignites, you know I am not the
_only_ one to blame.

Nothing of this should affect compilation and linking of the other
targets.
Downsample defeat2.ogg and victory2.ogg from 48 KHz to 44.1 KHz

44.1 KHz is the standard used for all other Wesnoth tracks and it's the
default sample rate used by SDL_Mixer. Playing music with any other
sample rate at 44.1 KHz results in sound distortion of sorts (in this
case, the pitch changes) since SDL_Mixer cannot do resampling. This
leads to music tracks not sounding as intended by the artist when played
in-game.

I dealt with this issue ages ago and claimed there weren't any tracks
left with nonstandard sample rates, but it seems I just overlooked these
two.
record unit recuitment before unit creation.
Merge branch 'master' of https://github.com/cbeck88/wesnoth-old into era-lua-hook