I would prefer a noop listener to not having a cancel button
On Aug 27, 2013 10:57 AM, "Jesse Rosalia" <notifications@github.com> wrote:

> In
> SoundStream/src/com/thelastcrusade/soundstream/components/WithBluetoothEnabled.java:
>
> > +        if (!connectionService.isNetworkEnabled()) {
> > +            Builder builder = new AlertDialog.Builder(context);
> > +            builder.setTitle(R.string.enable_bluetooth)
> > +                   .setMessage(R.string.ask_enable_bluetooth)
> > +                   .setPositiveButton(R.string.enable, new DialogInterface.OnClickListener() {
> > +
> > +                        @Override
> > +                        public void onClick(DialogInterface dialog, int which) {
> > +                            if (connectionService.enableNetwork()) {
> > +                                handler.post(runnable);
> > +                            } else {
> > +                                Log.wtf(TAG, "Error enabling bluetooth");
> > +                            }
> > +                        }
> > +                    })
> > +                   .setNegativeButton(android.R.string.cancel, new DialogInterface.OnClickListener() {
>
> I think if we don't, it wont display a cancel button (i'll verify this
> today). If that's the case, do we prefer no cancel button, or a NOOP
> listener?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/TheLastCrusade/SoundStream/pull/308/files#r6008898>
> .
>