you should write some Rspec tests for this