i#1105: Revert "Use a stack allocated buffer for private_instr_encode"

This reverts r1970.  I wasn't able to quickly come up with a good
solution to encoding instr immediates without truncation assertions.

TBR

Review URL: https://codereview.appspot.com/7513046

git-svn-id: https://dynamorio.googlecode.com/svn/trunk@1972 49cc7528-f6fd-11dd-9d1a-b59b2e1864b6
Ignore stderr from the linker when checking from gold

This was manifesting as a cmake warning when building external clients.
When gcc is using ld.bfd, it calls collect2 which always prints to
stderr, so there's no reason to check it.

Fixes issue 1109.

Review URL: https://codereview.appspot.com/7512043

git-svn-id: https://dynamorio.googlecode.com/svn/trunk@1973 49cc7528-f6fd-11dd-9d1a-b59b2e1864b6
Insert a space between string literals and macro identifiers

Fixes warnings for users who build clients with -std=c++11/-std=c++0x.
C++11 will lex these as user-defined string literals.

Review URL: https://codereview.appspot.com/7490044

git-svn-id: https://dynamorio.googlecode.com/svn/trunk@1974 49cc7528-f6fd-11dd-9d1a-b59b2e1864b6