What would be the reason for that? If to optimize to avoid string
concatenation, I think that would be over-optimizing and adding 2 extra
lines of code that just add noise. If the log statement was within a loop
or repeatedly called, I could see doing it, but that's not the case here.


On Mon, Oct 28, 2013 at 3:46 AM, Peter Veentjer <notifications@github.com>wrote:

> In
> hazelcast/src/main/java/com/hazelcast/instance/HazelcastInstanceFactory.java:
>
> > @@ -117,6 +117,7 @@ public static HazelcastInstance newHazelcastInstance(Config config, String insta
> >              final boolean firstMember = (iter.hasNext() && iter.next().localMember());
> >              final int initialWaitSeconds = node.groupProperties.INITIAL_WAIT_SECONDS.getInteger();
> >              if (initialWaitSeconds > 0) {
> > +                hazelcastInstance.logger.info("Waiting " + initialWaitSeconds + " seconds before completing node startup...");
>
> Can you add something like
>
> if(hazelcastInstance.logger.isInfoEnabled()){
> hazelcastInstance.logger.info("Waiting " + initialWaitSeconds + " seconds
> before completing node startup...");
> }
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hazelcast/hazelcast/pull/1051/files#r7241528>
> .
>