remove __tmp_oo_rename3

this test didn't clean up after itself

Reviewed By: enis

Differential Revision: D1084661
Some changes to Zend test importer

- Make it not fatal if the zend path don't contain a / in the end
- Better error message when using --only and it doesn't match any files

Reviewed By: @ptarjan

Differential Revision: D1083278
Refactor intl subcomponents into the intl extension

Mostly organizational frufaru
This moves us away from having multiple icu_* extensions
and closer to having a single 'intl' extension
similar to Zend.  icu_ucnv and icu_uspoof will be
folded in when they are converted to HNI.

Future intl classes (DateFormatter) will be added here.

Reviewed By: @ptarjan

Differential Revision: D1083189
Create php symlink for OSS

We don't have a php symlink to the hhvm executable in oss land. Create one so Pear can work correctly. Otherwise we will literally have 0% for Pear.

Reviewed By: @ptarjan

Differential Revision: D1084685
Remove --no-edit from pull requests

--no-edit for pull requests was causing issues on Ubuntu 12.04 running the script.

Error was: error: unknown option `no-edit'

Took it out. Things ran fine. Pull requests still worked for doctrine and pear.

Reviewed By: @alexmalyshev

Differential Revision: D1084828
preg_replace error return values

Fixed preg_replace error return values

Reviewed By: @ptarjan

Differential Revision: D1077072
Replace unused ObjectData::HasCallStatic with ObjectData::HasClone, use it

A measurable percentage of L1 dcache misses in production are
coming from lookups of the __clone function in ObjectData::cloneImpl.
If a decent number of them don't have custom __clone functions, we can
just check an o_attributes bit (which we just checked in ::clone, so
it should still be in dcache).  (This diff doesn't avoid the redundant
load of o_attributes, though.)

Reviewed By: @ptarjan

Differential Revision: D1070758
Implement reusable service requests for ARM

While doing this, I made CodeCursor not depend on X64Assembler and moved
it into a different file.

Reviewed By: @jdelong

Differential Revision: D1083358
Stop VIXL from creating this vixl_stats.csv file

This file gets created unconditionally, for stats logging, even if you
don't have logging turned on. This is annoying. I'm removing that code
from the simulator; if you want stats logging, it's easy enough to add
it yourself by creating vixl::Instrument and adding it as a decoder
visitor (like I do with PrintDisassembler in enterTC).

Reviewed By: @swtaarrs

Differential Revision: D1084658
Correctly set connection fields in PDOMySqlStatement

PDOStatements have a field for their PDOConnection. Turns out
PDOMySqlStatements have an extra field that stores their
PDOMySqlConnection, which they use instead. Synchronize the two,
as currently it's not possible to run pdo_handle_error without
hitting throw_null_pointer_exception().

Reviewed By: @ptarjan

Differential Revision: D1084318
Make the "Run Test File" command better.

Make the "Run Test File" command for tests that don't have an expected status beter for frameworks that don't run in parallel. For those frameworks, the test run command does not contain the individual test. And currently we can't run the individual test that is not behaving as expected without jumping through a few manual hoops. Turns out there is access to the test name while we are running, even serially. Use it.

Reviewed By: @alexmalyshev

Differential Revision: D1085298
Adding a possible cache for enum values based on static arrays

When defining an enum it is useful to have the values cached in a static array given Enum don't change value

Reviewed By: @markw65

Differential Revision: D1086167
Disable inlining in ARM mode

It's not the ARM part that kills us here, but the interp-everything
part. The inlining code fails in a couple of different ways if the
instruction that pushes the ActRec is interped. We don't really have a
way to cleanly bail out of inlining if we discover that it's impossible
below the IRTranslator level.

Rather than put in a bunch of effort to sort out that situation,
I'm opting to punt until we get proper ARM codegen for FPush* and FCall,
at which point we should be able to turn on inlining without trouble.
I've tasked it so we don't forget.

Reviewed By: @jdelong

Differential Revision: D1085589
Revert "Add support for IsScalar"

This reverts commit 68bef5478c2495c8328b68b94f687edf4e52b9ae.

Reviewed By: aravind

Differential Revision: D1087216
fix fprintf flakeyness

I love zend

Reviewed By: @alexmalyshev

Differential Revision: D1087430
Set json_last_error + message from json_encode

Currently json_last_error and json_last_error_msg only return meaningful values after json_decode, which is confusing since the functions are defined and at first seem like they are fully implemented.

Reviewed By: @ptarjan

Differential Revision: D1078012
filter_input_array behaves differently from stock php

fix `filter_input_array(INPUT_SERVER, FILTER_UNSAFE_RAW)`

Reviewed By: @ptarjan

Differential Revision: D1081292
Fix cpu identification

I broke this when cleaning up some -fstrict-alias warnings.

Reviewed By: @jdelong

Differential Revision: D1087374
record filter test with parameterization

This shouldn't require you to be in the root when running.

Reviewed By: aravind

Differential Revision: D1087979
Allow building ext_zend_compat extensions

By default, zend source compatability remains disabled,
however you can now explicitly request compilation of the
infrastructure and the extensions it supports via:

  cmake -DENABLE_ZEND_COMPAT=ON .

Note that CMake caches -D defines between runs, so a later call
without ENABLE_ZEND_COMPAT will still retain the option enabled.
Either explicitly set it to OFF, or delete CMakeCache.txt if
switching between the two.