more work on ADSR